Message from deleted roster contacts do not appear in 'fullscreen'

[AlgoClaw]

Describe the bug
This is similar to the recently-resolved issues #1021 and #3163.

If a contact is deleted from a user's roster in converse.js any future messages from the deleted contact do not appear (similar to previous issue).

However, if a message is received from an entirely new contact, that message appears (fixing the previous issue)

To Reproduce
Steps to reproduce the behavior:

1. Delete a contact from your roster
2. Receive a message from that contact
   • Notification sound will play
   • Icon notification count will increment
   • Message does not appear

Expected behavior
Message should appear from deleted roster contact.

Environment:
Running latest build (10.1.8) via docker (https://github.com/conversejs/converse.js-docker)

Here is the converse.initialize of my index.html:

converse.initialize({
	theme: 'dracula',
	dark_theme: 'dracula',
	authentication: 'login',
	auto_away: 300,
	auto_reconnect: true,
	message_archiving: 'always',
	view_mode: 'fullscreen',
	allow_registration: false,
	allow_non_roster_messaging: true,
	auto_subscribe: true,
	auto_join_on_invite: true,
	allow_contact_requests: true,
	allow_chat_pending_contacts: true,
	time_format: 'YYYY-MMM-DD HH:mm:ss',
	auto_register_muc_nickname: true,
	auto_subscribe: true,
	enable_muc_push: true,
	muc_clear_messages_on_leave: false,
	auto_list_rooms: true,
	allow_contact_requests: true,
	clear_messages_on_reconnection: true,
	clear_cache_on_logout: true,
	show_desktop_notifications: 'all',
	show_background: true
});

[jcbrand]

Thanks for the bug report. I tried to reproduce the issue with a test and wasn't able to.

See here: 2885d98#diff-6ef86fb62f9aa43030563c9ec62279f7d6b2ba47309fac65e191f3cd887fb347R1367

[AlgoClaw]

@jcbrand

I tested again with the updated roster.js -- I am still having the same issue.

1. Fullscreen issue?
   Can you try this in fullscreen mode? I only use fullscreen mode.

2. Re-adding the contact works, but messaging alone does not.
   In your test, did Mercutio re-add Romeo as a contact before sending the second message? I found that if the removed contact (Mercutio) re-adds the recipient (Romeo) as a contact, the contact request will show up on the recipient (Romeo) side (with a corresponding roster entry).

However, if the removed contact (Mercutio) simply sends a second message in an already-open chat window, the message is sent, but the corresponding roster entry on the recipient side (Romeo) does not re-generate.

[AlgoClaw]

@jcbrand

I tested using 'overlayed', and it works as expected (this issue is not there). So, the problem seems to be with 'fullscreen'.

I noticed that in 'overlayed', a chat window appears for a non-roster contact, but the contact is not automatically added to the roster. I am guessing this is the issue with 'fullscreen' -- the chat area is controlled by selecting a roster contact.