Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[contracts] address solc compiler warnings #973

Closed
bohendo opened this issue Apr 7, 2020 · 2 comments
Closed

[contracts] address solc compiler warnings #973

bohendo opened this issue Apr 7, 2020 · 2 comments
Labels
Enhancement New feature or request p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns.

Comments

@bohendo
Copy link
Contributor

bohendo commented Apr 7, 2020 •
edited
Loading

Ideally we'd pay attention to solc compiler warnings to warn us of any issues.

Contracts are much harder to upgrade than other parts of our code, it'll be less risky for us if we notice & address issues as early as possible & compiler warnings are a big help w that.

Currently, there are so many warnings that any meaningful signal is lost to noise.

This will require us to upgrade to solidity v0.6, if this requires too many syntax changes or risks breaking anything then we should decrease the priority of this issue.
@bohendo bohendo added Enhancement New feature or request p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns. labels Apr 7, 2020
@bohendo
Copy link
Contributor Author

bohendo commented Apr 7, 2020 •
edited
Loading

blocked by lack of solidity 0.6 support by OpenZeppelin, revist this issue once they release v3
Track OpenZeppelin's progress here:
OpenZeppelin/openzeppelin-contracts#2068
OpenZeppelin/openzeppelin-contracts#2086

@ArjunBhuptani
Copy link
Member

Completed via #1122

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement New feature or request p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bohendo @ArjunBhuptani