Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unary GET support #196

Closed
rebello95 opened this issue Oct 13, 2023 · 4 comments · Fixed by #203
Closed

Unary GET support #196

rebello95 opened this issue Oct 13, 2023 · 4 comments · Fixed by #203

Comments

@rebello95
Copy link
Collaborator

This issue is to track support for Connect's Unary GET requests: https://connectrpc.com/docs/protocol#unary-get-request
@rebello95 rebello95 mentioned this issue Oct 13, 2023
Closed
@rebello95
Copy link
Collaborator Author

Related: apple/swift-protobuf#1477

@rebello95
Copy link
Collaborator Author

Adding the necessary configuration options upstream:

@rebello95 rebello95 mentioned this issue Oct 19, 2023
Merged
@rebello95
Copy link
Collaborator Author

Waiting for a 1.x to be tagged in SwiftProtobuf to include apple/swift-protobuf#1487

@rebello95
Copy link
Collaborator Author

#203

rebello95 added a commit that referenced this issue Nov 13, 2023
@rebello95
Add unary GET protocol support (#203)
5ba072f 
## Summary

Implements support for Connect unary GET requests per
https://connectrpc.com/docs/protocol#unary-get-request.

By default, this behavior is disabled and can be enabled through an
option on `ProtocolClientConfig` (as demonstrated in the Eliza app).
Behavior is exercised in a new conformance test, but I do intend to add
more unit tests for this after #208.

## Linked issues

- Requires apple/swift-protobuf#1487
- Related to apple/swift-protobuf#1478
- Related to apple/swift-protobuf#1480
- Resolves #196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unary GET protocol support connectrpc/connect-swift
1 participant
@rebello95