From 61026a52749534d0811a32953e2f561ad80ec4bd Mon Sep 17 00:00:00 2001 From: Michael Rebello Date: Thu, 28 Mar 2024 14:53:13 -0700 Subject: [PATCH] Fix CI not finding pinned version of conformance protos (#255) Fetching is currently failing because this sha is not included in shallow fetches. Using `tag` instead of `ref` should allow this commit to be found correctly. --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index ee52db0c..3f8caa78 100644 --- a/Makefile +++ b/Makefile @@ -45,10 +45,10 @@ cleangenerated: ## Delete all generated outputs .PHONY: generate generate: cleangenerated ## Regenerate outputs for all .proto files - cd Examples; buf generate https://github.com/connectrpc/examples-go.git#ref=$(EXAMPLES_PROTO_REF),subdir=proto + cd Examples; buf generate https://github.com/connectrpc/examples-go.git#tag=$(EXAMPLES_PROTO_REF),subdir=proto cd Libraries/Connect; buf generate - cd Tests/ConformanceClient; buf generate https://github.com/connectrpc/conformance.git#ref=$(CONFORMANCE_PROTO_REF),subdir=proto - cd Tests/UnitTests/ConnectLibraryTests; buf generate https://github.com/connectrpc/conformance.git#ref=$(CONFORMANCE_PROTO_REF),subdir=proto + cd Tests/ConformanceClient; buf generate https://github.com/connectrpc/conformance.git#tag=$(CONFORMANCE_PROTO_REF),subdir=proto + cd Tests/UnitTests/ConnectLibraryTests; buf generate https://github.com/connectrpc/conformance.git#tag=$(CONFORMANCE_PROTO_REF),subdir=proto .PHONY: installconformancerunner installconformancerunner: ## Install the Connect conformance test runner