msys2: Check if package exists before removing it #25973
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jspam thanks a lot for taking the time to report the issue and create a PR, we appreciate it. Me and @uilianries were talking this morning when checking your issue, and we were going to suggest checking if it's installed before removing it. This approach has the benefit of working with old devel versions, something like wdyt? |
base-devel 2024.11 does not contain pkgconf any more [1], and the attempt to remove it will resulting in "error: no targets specified (use -h for help)". [1] msys2/MSYS2-packages@ad465ec Resolves conan-io#25970.
jspam
force-pushed
the
20241118-msys2
branch
from
a8280ad
to
15fa001
Compare
jspam
changed the title
|
Good idea. I just didn't see any obvious way to access the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base-devel 2024.11 does not contain pkgconf any more [1], and the attempt to remove it will resulting in "error: no targets specified (use -h for help)".
[1] msys2/MSYS2-packages@ad465ec
Resolves #25970.
Summary
Changes to recipe: lib/[version]
Motivation
Details