Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected omissions from submodule exports (e.g., RIO.Vector.iforM_) #250

Open
genovese opened this issue Jan 3, 2023 · 2 comments
Open

Comments

@genovese
Copy link

genovese commented Jan 3, 2023

I have recently started using RIO and am liking it a lot so far. I have been surprised several times at omitted exports from RIO submodules that do not appear to be unsafe, unchecked, or partial. For example, iforM and iforM_ are not exported from RIO.Vector et al. even though they are exported from Data.Vector* and imapM, imapM_, forM, and forM_ are all exported from RIO. Similarly, unzip and unzipWith are not exported from RIO.Seq (though available as munzip and unzipWith' methods on internal instances) even though they are from Data.Sequence.

Are these inadvertent omissions or is there a guiding rationale behind them? If the latter, it would be helpful if the reasons were clarified in the documentation. Using RIO.* as a nice and coherent alternative to Data.* is handy, but less so if one has to check and special case imports of functions that fit the RIO conditions but are missing.

Thanks

@snoyberg
Copy link
Collaborator

snoyberg commented Jan 5, 2023

No particular reason I’m aware of.

@genovese
Copy link
Author

Good to know, thanks. It would be great if they were added in future versions.

I've continued to have a good experience with RIO, btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants