-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login? #3
Comments
Hi @osseonews, this Demo Store is designed to be SSG first and foremost. We could manage the sign-in, but the Sales Channel is not enough for a sign-up. Since having the sign-in is useless without the sign-up we decided to postpone it. |
@marcomontalbano Probably best to just scrap this actually. Nextjs13 made this type of set up obsolete, in a way, as they are going to deprecate getstaticpaths etc soon. Yes, you don't need to use the app folder in Next13, but it is clear where they are going. So seems like a waste of time to build on this, as they head towards RSC as a default. Maybe CommerceLayer can build out something in remix as an alternative? |
Hi @osseonews, when the RFC was first announced on May we knew that things would have changed some point in the near future. The idea is to update demo-store-core and use the new |
Umm. I'll have to disagree on this one. RSC doesn't work. Shopify dropped it. I trust they tried their best and they have unlimited $ and brains. I do not think the "app" folder will gain acceptance any time soon, like in the next year. RSC just has too many problems and even assuming they get the bugs worked out in lets say 6 months, how many people really want to refactor their code once again? |
I was referring to |
Yeah, I agree, but you don't need to cache anything. That stuff runs on build and then it's cached as a JSON file I believe (not sure exactly how it works under the hood). I've never had any issues with getStatic and works great. I don't think RSC will be any faster, or at least nothing that a regular human will notice. I guess we will see. For now I'm touching it. Stick with the old school stuff. |
I think adding Login for the Auth component would be very helpful. Most ecommerce websites will require the user to login, and some of your components require user Login, for a user/pw token.
The text was updated successfully, but these errors were encountered: