CN address locality issue (invalid for unknown reasons)

[bakkerpeter]

Hi,

I'm having a hard time trying to understand why the following address is not validated as correct. I'm using this address as an example: Marriott Shanghai

 $address = new \CommerceGuys\Addressing\Address(
        "CN",
        "Shanghai Shi",
        "Shanghai",
        "Huangpu District",
        "200003",
        null,
        "555 Middle Xizang Road",
        null,
        "Marriott",
        "John",
        null,
        "Doe",
        "en"
    );

$validator = Validation::createValidator();
$violations = $validator->validate($address, new AddressFormatConstraint());

It turns out that the locality is invalid. When trying to get to the source of the validation error I found that $subdivision could not retrieved from the subdevisionRepository and therefore it fails. I'm not sure what this causes or means, also I'm not sure if it's a bug or me doing something wrong regarding input.

$subdivision = $this->subdivisionRepository->get($values[$field], $parents);

AddressFormatConstraintValidator.php - LN113

If someone could point me out what is going wrong here that would be of great help, thanks!

[bojanz]

Sorry for the late response here.

These are the valid localities for "Shanghai Shi": https://github.com/commerceguys/addressing/blob/master/resources/subdivision/CN-41c52eb75de1872e3f7d008da80c7aaa.json

As you can see, "Huangpu Qu" is one of them, so "Shanghai" is the missing level.

This is a known issue documented in google/libaddressinput#86 which Google has failed to address for a long time. Now that we no longer auto-generate the subdivisions from Google, we'll be able to proceed with a fix, but I'll need to consult with @skyred about the right shape of the data.

[skyred]

Below uses the latest version of Address on Drupal,

"Shanghai" is not a province or state, and "Huangpu Qu" is not a city.

This is exactly same situation as D.C. in U.S.

So, I imagine if you do the same validation on an address in the D.C., then you would see the same invalidation?

[bakkerpeter]

@skyred I'm not sure if you are asking me a question?

[skyred]

I didn't look into the code, but from the UI I tested, it looks expected, and it is working for me.

[bakkerpeter]

I'm sorry, but I'm still not sure what you are saying. Please don't get me wrong, I appreciate your help but basically my question has nothing to do with Drupal whatsoever. I'm only curious to know is the validation error a bug (and therefore is the address valid) or is my input wrong (and thus the address is correctly marked as invalid).

When you say it is working for you I really have no idea if the validation error is caused by the first or the latter.

The thing is, if there is a bug in the underlaying Google data I totally understand that there is not much we can do in this repo but if there is a bug regarding the subDevision retrieval then maybe we can help this great package forward.

[bojanz]

We no longer just mirror the Google data, we've forked it (in 2.0.0-dev / master branch), so we can make whatever changes we deem necessary. I just don't know what they are in this case :)

[TerraSkye]

@bojanz if im looking at google/libaddressinput#86 this issue
@skyred suggesteda a fix : in the first comment to duplicate the adminstrative area

is this a solution we can implement?