Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Upgrade to jQuery UI 1.13.0 #46

Open
avoinea opened this issue Dec 18, 2021 · 6 comments · May be fixed by #56
Open

Security: Upgrade to jQuery UI 1.13.0 #46

avoinea opened this issue Dec 18, 2021 · 6 comments · May be fixed by #56

Comments

@avoinea
Copy link
Member

avoinea commented Dec 18, 2021

2021-12-18-164238_729x427_scrot

@wesleybl
Copy link
Member

I tried following the update steps described in:

https://github.com/collective/collective.js.jqueryui/blob/master/docs/UPGRADE.txt

However, the jqueryui 1.13.1 download no longer makes the code separate from the plugins available. See:

https://jqueryui.com/download

This hampers the choice plugins functionality, described in:

https://github.com/collective/collective.js.jqueryui#include-plugins-and-optimizations

One option would be to clone the jqueryui repository and build it to generate the files. But that makes things more complicated.

So I ask if we can remove this functionality, or if it is really important.

@mauritsvanrees @agitator @avoinea @toutpt @maethu

@mauritsvanrees
Copy link
Member

Being able to slim the javascript down is a useful option. But upstream has made this impossible/difficult, then we may need to remove this. Would need be a a major breaking release I would say.
But I don't actively use this package.

@maethu
Copy link
Member

maethu commented Apr 28, 2022

I agree. If removed it simply should be a new major release with a hint in the README.

@szakitibi
Copy link

I agree. If removed it simply should be a new major release with a hint in the README.

Something like this?
jQueryUI 1.13.2 - https://github.com/szakitibi/collective.js.jqueryui

@wesleybl
Copy link
Member

@szakitibi would you like to contribute to the collective.js.jqueryui? Please open a issue at:

https://github.com/collective/Collective/issues

and ask to add to the collective organization. So you can create a branch here in this repository.

@szakitibi szakitibi linked a pull request Jun 20, 2023 that will close this issue
@szakitibi
Copy link

and ask to add to the collective organization. So you can create a branch here in this repository.

collective/Collective#1785 (comment) :D

Well to avoid complications I simply created the pull request see #56.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants