Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-ebml convert engine issue after Chrome Version 92.0.4515.107 (Official Build) (x86_64) on macos #613

Closed
Josmolmor opened this issue Oct 4, 2021 · 2 comments

Comments

@Josmolmor
Copy link

Josmolmor commented Oct 4, 2021

Hi, known issue with ts-ebml that has been going on for a while already after certain chrome version on macOS is happening on the videojs-record version of the library.

Description

This issue on the official repo pretty much summarizes everything, including an example where you can see it being replicated:
legokichi/ts-ebml#33

Attached is an image of mine of the issue happening:
image

Solution

We've done the following to solve the issue on other projects where we use the library:

fileReader.onload = function (): void {
        const result = this.result as ArrayBuffer;
        const ebmlElms: any = decoder.decode(result);
        ebmlElms.forEach((element: any): void => {
          reader.read(element);
        });
        ebmlElms
          // [ADMIN-2727] https://github.com/legokichi/ts-ebml/issues/33
          .filter(({ type }: { type: any }) => type !== 'unknown')
          .forEach((element: any): void => {
            reader.read(element);
          });
        reader.stop();
        const refinedMetadataBuf: any = tools.makeMetadataSeekable(reader.metadatas, reader.duration, reader.cues);
        const body: ArrayBuffer = result.slice(reader.metadataSize);

Thanks.

@Josmolmor
Copy link
Author

ended up doing it manually instead of using the converter

@thijstriemstra
Copy link
Member

ended up doing it manually instead of using the converter

Can you elaborate, perhaps it helps others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants