Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nurse: if the is no repository, unistall all the plugin #258

Open
vincenzopalazzo opened this issue Apr 9, 2024 · 1 comment
Open

nurse: if the is no repository, unistall all the plugin #258

vincenzopalazzo opened this issue Apr 9, 2024 · 1 comment
Labels
🎯 - triage Need to triage meeting enhancement New feature or request
Milestone

Comments

@vincenzopalazzo
Copy link
Contributor

It possible fall under a state (if you mess up with a buggy version of coffee) that you have the plugin installed but you have no repository.

So Coffee should remove all the plugins installed when there is no repository.

@vincenzopalazzo vincenzopalazzo added enhancement New feature or request 🎯 - triage Need to triage meeting labels Apr 9, 2024
@vincenzopalazzo vincenzopalazzo added this to the 0.1-rc1 milestone Apr 9, 2024
@tareknaser
Copy link
Collaborator

Good idea
We could even make the new nurse strategy more general in a sense that:

  • For each plugin, check for the its remote repository
  • We need the remote repository to exist so we can perform update for example
  • If it doesn't exist, remove the plugin

Only concern I have is that we currently have 1 nurse strategy GitRepositoryLocallyAbsentStrategy and we are adding another one in #239. If we have too many nurse strategies, we check for too many things before each command run.
Might be a good time to make skip-verify a default.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 - triage Need to triage meeting enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants