Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we should move the repository directory inside a network directory #234

Open
vincenzopalazzo opened this issue Feb 7, 2024 · 2 comments · May be fixed by #239
Open

we should move the repository directory inside a network directory #234

vincenzopalazzo opened this issue Feb 7, 2024 · 2 comments · May be fixed by #239
Assignees
@vincenzopalazzo
Labels
🐛 - bug Something isn't working ❤️ - RFC Request for Comments, it is under consideration
Milestone
0.1-rc1

Comments

@vincenzopalazzo
Copy link
Contributor

I try to run

➜  ~ coffee --network testnet remote add folgore-git https://github.com/coffee-tools/folgore.git
✓ Remote added!
➜  ~ coffee remote add folgore-git https://github.com/coffee-tools/folgore.git
✗ Fetch remote from https://github.com/coffee-tools/folgore.git error: Error while add remote: code: 1, msg: repository with name: folgore-git already exists
✗ Error: code: 1, msg: repository with name: folgore-git already exists

This must not happen, because for each network we can add a different remote (e.g: a fork for testnet) so we should move the repository inside the network subdirectory
@vincenzopalazzo vincenzopalazzo added 🐛 - bug Something isn't working ❤️ - RFC Request for Comments, it is under consideration labels Feb 7, 2024
@vincenzopalazzo vincenzopalazzo added this to the 0.1-rc1 milestone Feb 7, 2024
@vincenzopalazzo vincenzopalazzo self-assigned this Feb 7, 2024
vincenzopalazzo added a commit that referenced this issue Feb 7, 2024
@vincenzopalazzo
feat(core): make a repository dir for each network
472d9f6 
This is the more sane thing to do because each network
can have a different repository version.

Link: #234
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo linked a pull request Feb 7, 2024 that will close this issue
Open
@tareknaser
Copy link
Collaborator

I am fully with this.

There are so many scenarios where this feature would come in handy. This would also be useful when we add coffee upgrade --branch <branch_name>

@vincenzopalazzo
Copy link
Contributor Author

Yeah this si my fault that I tough that the repository was not needed as a network information

vincenzopalazzo added a commit that referenced this issue Apr 9, 2024
@vincenzopalazzo
feat(core): make a repository dir for each network
1bf8a24 
This is the more sane thing to do because each network
can have a different repository version.

Link: #234
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit that referenced this issue Apr 14, 2024
@vincenzopalazzo
feat(core): make a repository dir for each network
94b697e 
This is the more sane thing to do because each network
can have a different repository version.

Link: #234
Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
🐛 - bug Something isn't working ❤️ - RFC Request for Comments, it is under consideration
Projects
None yet
Milestone
0.1-rc1
Development

Successfully merging a pull request may close this issue.

feat(core): make a repository dir for each network coffee-tools/coffee
2 participants
@vincenzopalazzo @tareknaser