Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use docker for default install #194

Open
jackstar12 opened this issue Aug 13, 2023 · 1 comment
Open

use docker for default install #194

jackstar12 opened this issue Aug 13, 2023 · 1 comment
Assignees
Labels
💭 - brainstorming feature idea and related discussion ❤️ - RFC Request for Comments, it is under consideration 🎯 - triage Need to triage meeting enhancement New feature or request

Comments

@jackstar12
Copy link
Contributor

Currently default plugin installation is only implemented for pip and poetry, which is suboptimal.

Figuring this out for compiled languages would be pretty hard because you need to figure out how to detect / install each toolchain, which is why I propose using docker or podman (daemonless docker) for building the plugin into a container which cln can then run through a small generated script. Each language could have a default image or provide a custom one in coffee.yaml.

If docker / podman isn't installed on the machine we could still fallback to the current way of doing things.

I'd be willing to try implement this.

@vincenzopalazzo
Copy link
Contributor

Currently default plugin installation is only implemented for pip and poetry, which is suboptimal.

Currently, with coffee.yml we support all the plugins, and I would like to see it as a standard because you can also have a missing python dir. but yeah you are right.

If docker / podman isn't installed on the machine we could still fallback to the current way of doing things.

Yeah correct, do you think that this required some change inside the coffee core? or it is possible to do just with coffee.yml?

I'd be willing to try implement this.

I would love to see it, please do if you need to chat more about it there is a Discussion open in the github repository

Thanks for this good point

@vincenzopalazzo vincenzopalazzo added enhancement New feature or request 💭 - brainstorming feature idea and related discussion ❤️ - RFC Request for Comments, it is under consideration 🎯 - triage Need to triage meeting labels Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💭 - brainstorming feature idea and related discussion ❤️ - RFC Request for Comments, it is under consideration 🎯 - triage Need to triage meeting enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants