feat: Add command to generate skeleton for Barq strategy #15
Conversation
There was a problem hiding this comment.
Hey, thanks for working on this!
I appreciate the effort, but I'm not entirely sure we need this command. I just think that adding a new strategy in Rust is actually pretty straightforward and can be done quickly by someone with basic Rust skills.
Could you share your thoughts on why you think this would be beneficial?
I've also added a few comments in the review to address if we decide to move forward with it.
Thanks again!
| }; | ||
|
|
||
| #[test] | ||
| fn test_direct_routing() { |
There was a problem hiding this comment.
I think you should modify this too?
|
|
||
| impl Strategy for $capitalized_script_name { | ||
| fn can_apply(&self, input: &RouteInput) -> Result<bool> { | ||
| // TODO: implement logic which checks if this strategy can be applied to given network graph |
There was a problem hiding this comment.
These will cause compilation errors. The function returns Result<bool>, so we need to return Ok(true) in the template.
| fn route(&self, input: &RouteInput) -> Result<RouteOutput> { | ||
| // TODO: implement routing algorithm | ||
| } |
There was a problem hiding this comment.
This change is missing an inclusion line in lib.rs, causing it to fail to compile.
There was a problem hiding this comment.
I believe we should also include some usage instructions, at least mentioning it in the README.
There was a problem hiding this comment.
This script doesn't add the strategy to barq-plugin crate for routing, so it remains unused.
Currently, developers need to manually write the skeleton for a new Barq strategy from scratch. This change introduces a new command that automates the creation of the skeleton for a Barq strategy. This enhancement streamlines the development process by providing a ready-to-use template, allowing developers to focus on implementing the strategy logic.
solves #14