Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting button-size larger than value at first render causes clipped image #56

Open
lambdadog opened this issue Apr 9, 2022 · 2 comments

Comments

@lambdadog
Copy link
Contributor

lambdadog commented Apr 9, 2022

It took me a bit to hunt down exactly the circumstances of this bug, but what buttonSize is set to at first render seems to be a "max" for button-size changes without clipping after that.

Due to this, it's possible to increase button-size from 14 by setting it in your rcfile (which is executed before first render), but any increases at runtime cause the image to be clipped on the right side.

ex:

(with button-size set to 20 in rcfile)
wormc20

(after wormc button-size 22 is run)
wormc22

@lambdadog
Copy link
Contributor Author

If you don't set button-size in your rcfile this manifests as clipping for any button-size greater than 14, as 14 is the default initial value.

@codic12
Copy link
Owner

codic12 commented Apr 10, 2022

This can actually be fixed by triggering a re-render by moving the window around or resizing it. The issue is I think the image is re-rendered without the window being resized in the section of the ClientMessage handler which sets button-size. I'll try to fix tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants