From 16efbdf84fb98dd357bb4e02c977c826488886ab Mon Sep 17 00:00:00 2001 From: Lukas Krejci Date: Fri, 6 Sep 2024 14:47:00 +0200 Subject: [PATCH 1/3] Don't use or test ToolchainCluster.Spec.CABundle. --- pkg/test/cluster.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/test/cluster.go b/pkg/test/cluster.go index a259fa23..c62ee040 100644 --- a/pkg/test/cluster.go +++ b/pkg/test/cluster.go @@ -49,7 +49,6 @@ func NewToolchainClusterWithEndpoint(t *testing.T, name, tcNs, operatorNs, secNa Name: secName, }, APIEndpoint: apiEndpoint, - CABundle: "", DisabledTLSValidations: []toolchainv1alpha1.TLSValidation{toolchainv1alpha1.TLSAll}, }, ObjectMeta: v1.ObjectMeta{ From 7422f0abd59835d5fd8c8fc22cab230049d8c3c2 Mon Sep 17 00:00:00 2001 From: Lukas Krejci Date: Fri, 6 Sep 2024 14:48:44 +0200 Subject: [PATCH 2/3] Don't use or test for ToolchainCluster.Spec.DisabledTLSValidations. --- pkg/test/cluster.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/test/cluster.go b/pkg/test/cluster.go index c62ee040..a6527117 100644 --- a/pkg/test/cluster.go +++ b/pkg/test/cluster.go @@ -48,8 +48,7 @@ func NewToolchainClusterWithEndpoint(t *testing.T, name, tcNs, operatorNs, secNa SecretRef: toolchainv1alpha1.LocalSecretReference{ Name: secName, }, - APIEndpoint: apiEndpoint, - DisabledTLSValidations: []toolchainv1alpha1.TLSValidation{toolchainv1alpha1.TLSAll}, + APIEndpoint: apiEndpoint, }, ObjectMeta: v1.ObjectMeta{ Name: name, From 0d27ea51fd3e361d44dd248fc85922acf5519d9e Mon Sep 17 00:00:00 2001 From: Lukas Krejci Date: Fri, 6 Sep 2024 14:55:46 +0200 Subject: [PATCH 3/3] Don't set ToolchainCluster.Spec.APIEndpoint because it is not used for anything. --- pkg/test/cluster.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/test/cluster.go b/pkg/test/cluster.go index a6527117..7a12bf3e 100644 --- a/pkg/test/cluster.go +++ b/pkg/test/cluster.go @@ -48,7 +48,6 @@ func NewToolchainClusterWithEndpoint(t *testing.T, name, tcNs, operatorNs, secNa SecretRef: toolchainv1alpha1.LocalSecretReference{ Name: secName, }, - APIEndpoint: apiEndpoint, }, ObjectMeta: v1.ObjectMeta{ Name: name,