Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to scan elb and filter unused security groups that are attached to elb #17

Open
rohanagrawal-amex opened this issue Aug 18, 2022 · 3 comments
Open

Add ability to scan elb and filter unused security groups that are attached to elb #17

rohanagrawal-amex opened this issue Aug 18, 2022 · 3 comments

Comments

@rohanagrawal-amex
Copy link

Add ability to scan elb and filter unused security groups that are attached to elb
@rohanagrawal-amex
Copy link
Author

I will submit the PR soon for this

@fleaz
Copy link
Contributor

fleaz commented Aug 19, 2022

What do you mean by "unused security groups that are attached to elb"?

@rohanagrawal-amex rohanagrawal-amex mentioned this issue Aug 19, 2022
Open
4 tasks
@rohanagrawal-amex
Copy link
Author

rohanagrawal-amex commented Aug 19, 2022 •
edited
Loading

hi @fleaz - sorry i should have been more descriptive on the issue. What i meant is since currently the code doesn't scan for elb so any security groups those are tied to elbs and not used by any other aws resources are also being flagged for being unused. I have added this PR: #18 that will add the elb scan feature as well as remove any security groups from unused sg in case an elb was using that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fleaz @rohanagrawal-amex