Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put password health results into some kind of global state to cache it per "application session" #21

Open
jonas-pietzsch opened this issue Apr 10, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jonas-pietzsch
Copy link
Contributor

jonas-pietzsch commented Apr 10, 2019

The password health should only be reviewed once per application usage.

@jonas-pietzsch jonas-pietzsch changed the title Put password health results into global state to cache it per "application session" Put password health results into some kind of global state to cache it per "application session" Apr 12, 2019
@jonas-pietzsch
Copy link
Contributor Author

Refactored the global password-health feature in a way that rating was removed from the rendering process. It is now deterministic when the state is ready and when it has stored a finished password-rating result. This result can be taken to be persisted for a temporary time now. It could be invalidated by:

  • Simply time: it gets a max age, when it's over the check will run again
  • All secrets' checksum (can we get a checksum over all stores from Gopass?!): if something changed, calculate again
  • Edited/removed/added secrets through Gopass UI. Disadvantage of not tracking modifications via CLI...

@jonas-pietzsch
Copy link
Contributor Author

TODO: put the finished results into the system settings. First iteration will use the "simply time" implementation to keep it simple ATM.

@jonas-pietzsch jonas-pietzsch added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 13, 2020
@svenXY
Copy link

svenXY commented Apr 29, 2020

In addition, it would be great if one could go back to the list directly after having selected and inspected one of the suggested improvements.

Besides, except the colour, it is not clear that these passwords can be clicked on in the first place. At least the cursor icon could change or similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants