Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to vite #395

Closed
joshreisner opened this issue Jun 29, 2024 · 2 comments · Fixed by #423
Closed

switch to vite #395

joshreisner opened this issue Jun 29, 2024 · 2 comments · Fixed by #423
Assignees

Comments

@joshreisner
Copy link
Contributor

we use laravel mix to build our javascript, which is odd since this isn't a laravel project - and even laravel is using vite now so it's time for us to make the switch

the important thing that mix does is bundle our javascript into a single, predictable url at /public/app.js. we also need to confirm that the minified size is roughly the same: ~1.4m

then update the steps for contributing in readme

@joshreisner
Copy link
Contributor Author

figured this out!! in vite.config.js:

export default {
  build: {
    rollupOptions: {
      output: {
        entryFileNames: "app.js",
      },
    },
  },
};

@joshreisner joshreisner self-assigned this Sep 20, 2024
@joshreisner
Copy link
Contributor Author

/app.js | 1.37 MiB
/app.js.LICENSE.txt │ 1.94 KiB

@joshreisner joshreisner linked a pull request Oct 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant