Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite integration tests for skill-button-test component #1621

Open
daveconnis opened this issue Dec 14, 2017 · 0 comments
Open

Rewrite integration tests for skill-button-test component #1621

daveconnis opened this issue Dec 14, 2017 · 0 comments

Comments

@daveconnis
Copy link
Contributor

Problem

Currently, tests/integration/components/skill-button-test.js doesn't make full use of its page object by not defining a renderPage() function. To dry up the code, you can set a renderPage() function above the moduleForComponent, pass in the needed hbs selectors, and call renderPage() in each test.

References

#1605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daveconnis