Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Merge project approved and approval_requested flags into a single field #1279

Open
begedin opened this issue Dec 6, 2017 · 0 comments

Comments

@begedin
Copy link
Contributor

begedin commented Dec 6, 2017

Problem

Looking at these two fields, it really seems they serve a singular purpose.

# A project is created 
`approved: false, approval_requested: false`
# User submits project for approval 
`approved: false, approval_requested: true`
# Admin approves project 
`approved: true, approval_requested :does_not_matter`

A single field, for example,

# 'created' -> 'pending_approval' -> 'approved'
field :onboarding_status, :string, null: false, default: 'created' 

Might serve our purposes much better.

We could add an additional status of rejected later, with an additional field of rejected_reason or something.

@joshsmith joshsmith changed the title Discussion: Merge project approved and approval_requested flags into a single field RFC: Merge project approved and approval_requested flags into a single field Jan 1, 2018
@joshsmith joshsmith added the RFC label Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants