Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation errors for timestamps in GitHub syncing to not error but ignore #1115

Open
joshsmith opened this issue Oct 24, 2017 · 3 comments

Comments

@joshsmith
Copy link
Contributor

joshsmith commented Oct 24, 2017

Problem

Right now if there are validation errors due to timestamps being off in GitHub syncing, it appears we're seeing validating_tasks or validating_comments errors. What we should do instead is actually ensure that if the timestamps are off, that we instead say the event payload was ignored due to timestamp differences.

@begedin
Copy link
Contributor

begedin commented Oct 30, 2017

This would be a matter of interpreting a transaction outcome as an :ok.

~ 2 hours to make the changes and update tests. Bulk of the time will likely be in tests.

@joshsmith
Copy link
Contributor Author

Related to issue raised in #1148, it looks like we may need to consider this even more fully here.

If something is syncing from GitHub but the timestamp is outdated on GitHub's side, it should not just be ignored; it likely also needs to kick off a resync to GitHub for that Task or Comment.

@joshsmith
Copy link
Contributor Author

The passing test in #1198 can serve as the basis for writing a failing test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants