You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the default build with no admin privs does work as expected
the build with admin privs does not work. It only shows lost pings but with wireshark i could not see any icmp packets beeing sent. So that does not seem to work. I added some debug prints and sendto returns an expected value of 20. My windows debugging skills are at my limit there.
[...]
Even tho the version with admin privileges is broken i believe this PR is "completed" as on the current master this doesn't even compile. So i consider that feature "not made worse" 😄
I just wanted to have this documented, there is probably no real use in the "with admin prives" version anymore. Maybe we could consider removing the code and making the no admin version the only available.
The text was updated successfully, but these errors were encountered:
dreua
changed the title
Broken on windows with admin priviledges
Windows: Old "with admin priviledges" version is broken
May 17, 2024
Before we do remove that code, did someone other than me checked if it works? I have only tested it on one single machine, that might have some other (Group Policy) reasons for this to not work. Like i said, my windows debugging skills are limited.
But anyways:
I am in favor of removing that code, as that is quite a lot of code, that is
sendto
returns an expected value of 20. My windows debugging skills are at my limit there.[...]
Even tho the version with admin privileges is broken i believe this PR is "completed" as on the current master this doesn't even compile. So i consider that feature "not made worse" 😄
Originally posted by @mrbesen in #109 (comment)
I just wanted to have this documented, there is probably no real use in the "with admin prives" version anymore. Maybe we could consider removing the code and making the no admin version the only available.
The text was updated successfully, but these errors were encountered: