Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show method and remove dead code #170

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

cmhamel
Copy link
Owner

@cmhamel cmhamel commented Jan 14, 2024

Addresses issue #160

…tever reason. You'd think an NTuple of types for a return type would be type stable?
…ith id 6 has no name in the db, we give it a name 'unnamed_block_6' so it can be easily indexed by name and also resolves some confusing print issues when loading up a db.
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7780123) 85.80% compared to head (381721a) 88.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   85.80%   88.87%   +3.06%     
==========================================
  Files          18       18              
  Lines        1240     1231       -9     
==========================================
+ Hits         1064     1094      +30     
+ Misses        176      137      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmhamel cmhamel merged commit 75be91e into master Jan 14, 2024
8 of 12 checks passed
@cmhamel cmhamel deleted the fix-show-method-and-remove-dead-code branch January 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant