Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define a main bin file #29

Open
clue opened this issue Mar 12, 2014 · 5 comments
Open

Explicitly define a main bin file #29

clue opened this issue Mar 12, 2014 · 5 comments

Comments

@clue
Copy link
Owner

clue commented Mar 12, 2014

Currently, we only try to take the first bin listed in composer.json.

Aditionally, we should offer a way to define a main file either through a command line option or a config key extra.phar.main.

@clue clue mentioned this issue Nov 7, 2015
shivas added a commit to shivas/phar-composer that referenced this issue Nov 17, 2015
@shivas
Copy link

shivas commented Jan 26, 2016

@clue ping

@clue
Copy link
Owner Author

clue commented Jul 14, 2016

Thanks for your PR and the ping @shivas 👍

This hasn't seen any traction because I'm currently undecided on the project direction and would love to hear some more thoughts on this.

The README currently says this is "zero configuration" project and we're starting to add the first configuration keys.

That being said, I think this feature makes perfect sense in certain cases.

Another thing to keep in mind is that we can also build arbitrary composer packages like this:

$ phar-composer build vendor/package

Once we start adding these configuration keys, one would likely also expect these are also accepted for external packages. I'm unsure how this could even work out.

What are your thoughts on this?

@shivas
Copy link

shivas commented Jul 18, 2016

Well, i don't know about "zero configuration", i mean it's still 0 configuration if you are fine with defaults (and 95% is fine with defaults i guess). In my case i needed such parameter, so instead to just make myself a copy i decided to fill this PR.

@abcarroll
Copy link

Just would like to be known that I found this project and found it highly interesting, however no where in the README.md does it state this functionality, and landed here trying to find what phar-composer's behavior was regarding the entry point.

Concurring with @shivas, I would understand "Zero Configuration" as in "Zero Configuration Necessary to get Up and Running", ... not "Zero Customization without Directly Modifying the Source".

Regardless, thank you for the excellent software package!

@clue
Copy link
Owner Author

clue commented Nov 8, 2019

Thanks for commenting on this @shivas and @abcarroll, I agree with what you're saying, let's stick to the "zero configuration required" interpretation of things and let's move forward with this feature 👍

@clue clue added this to the v1.2.0 milestone Nov 12, 2019
@clue clue modified the milestones: v1.2.0, v1.3.0 Dec 11, 2020
@clue clue removed this from the v1.3.0 milestone Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants