-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly define a main bin file #29
Comments
@clue ping |
Thanks for your PR and the ping @shivas 👍 This hasn't seen any traction because I'm currently undecided on the project direction and would love to hear some more thoughts on this. The README currently says this is "zero configuration" project and we're starting to add the first configuration keys. That being said, I think this feature makes perfect sense in certain cases. Another thing to keep in mind is that we can also build arbitrary composer packages like this: $ phar-composer build vendor/package Once we start adding these configuration keys, one would likely also expect these are also accepted for external packages. I'm unsure how this could even work out. What are your thoughts on this? |
Well, i don't know about "zero configuration", i mean it's still 0 configuration if you are fine with defaults (and 95% is fine with defaults i guess). In my case i needed such parameter, so instead to just make myself a copy i decided to fill this PR. |
Just would like to be known that I found this project and found it highly interesting, however no where in the README.md does it state this functionality, and landed here trying to find what phar-composer's behavior was regarding the entry point. Concurring with @shivas, I would understand "Zero Configuration" as in "Zero Configuration Necessary to get Up and Running", ... not "Zero Customization without Directly Modifying the Source". Regardless, thank you for the excellent software package! |
Thanks for commenting on this @shivas and @abcarroll, I agree with what you're saying, let's stick to the "zero configuration required" interpretation of things and let's move forward with this feature 👍 |
Currently, we only try to take the first
bin
listed incomposer.json
.Aditionally, we should offer a way to define a main file either through a command line option or a config key
extra.phar.main
.The text was updated successfully, but these errors were encountered: