Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sending metrics to Prometheus #16

Open
liu-song opened this issue Apr 14, 2023 · 2 comments
Open

Support for sending metrics to Prometheus #16

liu-song opened this issue Apr 14, 2023 · 2 comments
Labels
C-proposal A proposal of some kind, and a request for comments. state: pending

Comments

@liu-song
Copy link
Contributor

liu-song commented Apr 14, 2023

Is your feature request related to a problem? Please describe.

目前Monitor 接口没有具体实现,无法获得程序运行时的监控指标

Describe the solution you'd like

type Monitor interface {

   OnEmitSessionMetrics(PerformanceMetrics, StabilityMetrics, ShareMemoryMetrics, *Session)

   Flush() error
}

实现 Monitor 接口,其中OnEmitSessionMetrics 方法发送metrics 到prometheus , Flush() 方法将metrics写到本地日志文件

Describe alternatives you've considered
不太确定用那种实现方式

1 在业务代码里面实现Monitor 接口,然后提供一个使用的example,放在example路径中
2 直接在shmipc-go 库里实现,对外提供接口的实现,写一个使用的example

Additional context

@liu-song
Copy link
Contributor Author

assign

@GuangmingLuo
Copy link
Member

Thanks for your idea and PR contribution @liu-song . However, we won't proceed this until there is a specific user claim that they will use this feature in real scenario.

@GuangmingLuo GuangmingLuo added C-proposal A proposal of some kind, and a request for comments. state: pending labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-proposal A proposal of some kind, and a request for comments. state: pending
Development

No branches or pull requests

2 participants