-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extremely slow, slower than gnet by 40% benchmark because of syscall6 #937
Comments
Can you provide detailed code and pressure test environment? I only see hertz's code. |
@li-jin-gou wrk -t 1 -d 10 http://.... :8080 / 8081 ubuntu 22.04, i5, 4 threads cpu core pls try it out. |
@li-jin-gou trying to use this framework with "prefork mode" to compete in techempower benchmark do guide on how to make it faster. thx |
This is pr in TechEmpower/FrameworkBenchmarks#8483 @hiqsociety We found that the code for the benchmark was not the same, which could lead to inaccurate results.
|
I think hertz support for prefork could be a higher priority, as it seems like his performance gains are huge. @hiqsociety |
@li-jin-gou i dunno what this is about but hertz should be compared with gnet / fiber and it's still very slow compared to either. whatever mode you prefer, just make it faster than what it is currently. it's really too slow, defeats the purpose of using hertz.
|
@li-jin-gou it's fixed? possible to open this issue as a continual speed improvements update? is there any guidance on built in prefork mode for hertz or can just use mine? |
OK, #8483 already merged and @Skyenought will explore ways to optimize performance include Prefork etc in https://github.com/hertz-contrib/performance. |
this non-preforked results make hertz look so bad. my prefork version is accepted into the latest techempower benchmark repo. hope to be included in hertz as default prefork. |
Don't really want to maintain prefork as there is no real user demand for it. If a user wants to use prefork, I think it would be a good idea to refer them to your code. TechEmpower/FrameworkBenchmarks#8528 |
possible to fix this?
"prefork mode" of hertz for "Hello World!" for techempower benchmark
https://github.com/cloudxaas/gosprapp/blob/main/web/app/app.go
possible to provide guidance on how to speed it up?
gnet ~ 95k req/s
hertz ~ 55k req/s
that's almost 40% slower than gnet
The text was updated successfully, but these errors were encountered: