Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request:Please Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 to solve dev panic problem #229

Open
MuLeiSY2021 opened this issue Dec 26, 2024 · 0 comments

Comments

@MuLeiSY2021
Copy link

MuLeiSY2021 commented Dec 26, 2024

Is your feature request related to a problem? Please describe.

When Argument struct using "yaml:",inline"" tag,it cause panic

I'm working on [#23]https://github.com/cloudwego/cwgo/issues/114
And because Argument struct use many Embedded Struct pointer,
In gopkg yaml doc if use Embedded Struct,have to add "yaml:",inline"" tag,
But in version 2,is not support Embedded Struct pointer ,and it will cause panic,

Describe the solution you'd like

After testing, In version 3 this problem was already solved
The api of version 3 was almost not differ than version 2
So it is perfectly acceptable

Describe alternatives you've considered

If just to solve [#23]https://github.com/cloudwego/cwgo/issues/114
We slove can use Decoder to solve this problem,but if we want to add some new arg,it will be pretty hard to maintain
So the easiest way to solve this problem is to update version

Additional context
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant