Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'engine_version' is required when 'snapshot_identifier' is specified #154

Open
ragumix opened this issue May 4, 2023 · 0 comments
Open
Labels
bug 🐛 An issue with the system

Comments

@ragumix
Copy link
Contributor

ragumix commented May 4, 2023

Describe the Bug

Looks like there is a mistake in the module regarding the engine_version parameter. When snapshot_identifier parameter specified, it needs to specify engine_version parameter. If engine_version parameter is not specified, the following suggestion will be showed:

var.engine_version
Database engine version, depends on engine type. Required unless a snapshot_identifier or replicate_source_db is provided.

Enter a value:

According to the official documentation (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#engine_version), there is no mentioning that it doesn't need to specify engine_version when you specified snapshot_identifier.

Expected Behavior

Fix description for engine_version parameter. Please delete this sentence for engine_version:

Required unless a snapshot_identifier or replicate_source_db is provided.

Steps to Reproduce

Try to create RDS from snapshot without specifying engine_version parameter.

Screenshots

No response

Environment

No response

Additional Context

No response

@ragumix ragumix added the bug 🐛 An issue with the system label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

1 participant