Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 0.95.1 version is broken for multiple s3_origings #325

Open
rafaljanicki opened this issue Oct 10, 2024 · 0 comments
Open

The 0.95.1 version is broken for multiple s3_origings #325

rafaljanicki opened this issue Oct 10, 2024 · 0 comments
Labels
bug 🐛 An issue with the system

Comments

@rafaljanicki
Copy link
Contributor

Describe the Bug

With the release of https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/319/files , a bug was introduced in line 585: https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/319/files#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR585 . The for_each shouldn't be based on a number of s3_origins, but rather a single block at most should be there

BTW
This release is also breaking for a different reason - if one had s3_origins defined, with this patch version release, it breaks as it expects the origin_access_control_id argument. This should be released as a minor release, not a patch one

Expected Behavior

Have only one block s3_origin_config if defined

Steps to Reproduce

Create two s3_origins

Screenshots

No response

Environment

No response

Additional Context

No response

@rafaljanicki rafaljanicki added the bug 🐛 An issue with the system label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

1 participant