Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.0.0 of the aws provider contains breaking changes for this module #279

Open
jake-naughton opened this issue May 28, 2023 · 2 comments
Labels
bug 🐛 An issue with the system

Comments

@jake-naughton
Copy link

jake-naughton commented May 28, 2023

Describe the Bug

This module fails to build when using AWS provider with version >= v5.0.0

As outlined in the AWS provider release notes:

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

source_json and override_json have been removed -- use source_policy_documents and override_policy_documents, respectively, instead.

Expected Behavior

Should be able to run terraform plan / apply on the module without it failing using AWS provider > v5.0.0

Steps to Reproduce

Set the AWS provider to

required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 5"
    }
  }

And run terraform plan or apply on this module.

Screenshots

Screen Shot 2023-05-28 at 10 30 47 pm

Environment

  • Module version 0.90.0
  • Terraform version 1.3.9
  • AWS provider version 5.0.0

Additional Context

No response

@jake-naughton jake-naughton added the bug 🐛 An issue with the system label May 28, 2023
@jake-naughton jake-naughton changed the title An argument named "source_json" is not expected here Cersion 5.0.0 of the aws provider contains breaking changes for the CDN module May 28, 2023
@jake-naughton jake-naughton changed the title Cersion 5.0.0 of the aws provider contains breaking changes for the CDN module Cersion 5.0.0 of the aws provider contains breaking changes May 28, 2023
@jake-naughton jake-naughton changed the title Cersion 5.0.0 of the aws provider contains breaking changes Version 5.0.0 of the aws provider contains breaking changes May 28, 2023
@jake-naughton jake-naughton changed the title Version 5.0.0 of the aws provider contains breaking changes Version 5.0.0 of the aws provider contains breaking changes for this module May 28, 2023
@Vigneshwar-Mahendran
Copy link

we need this changes to be adapted for version 0.63.0 since I'm using tf13

@rafaljanicki
Copy link
Contributor

What at least could be done here is to add a constraint of < 5 in the versions.tf as otherwise, there's no easy way to make it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

3 participants