Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isEqual property to the form #289

Open
svenank3r opened this issue Jan 4, 2023 · 1 comment · May be fixed by #290
Open

Add isEqual property to the form #289

svenank3r opened this issue Jan 4, 2023 · 1 comment · May be fixed by #290

Comments

@svenank3r
Copy link

Currently when no changes are made to the form (in comparison with the intial value of the form), the manualSave$ will not trigger an output update and therefore you cant submit the form.

In this issue I promised to look into adding a property that exposes the isEqual check that is used during the manualSave.
As my solution does not solve the original issue that was reported, I created this new issue to do the pull request on.
@svenank3r svenank3r linked a pull request Jan 4, 2023 that will close this issue
Open
@maxime1992 maxime1992 mentioned this issue Jan 9, 2023
Closed
@NgrNxk
Copy link

NgrNxk commented Jan 11, 2023 •
edited
Loading

Oh yes, please! I would love to submit without changes! On a side-note: how can I trick ngx-sub-form into thinking the initial value is empty but still set a value with this.input$.next(entity)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/expose is equal svenank3r/ngx-sub-form
2 participants
@NgrNxk @svenank3r