Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List subform component not updated with OnPush strategy (v6.0.0) #195

Closed
temka1234 opened this issue Oct 30, 2020 · 3 comments
Closed

List subform component not updated with OnPush strategy (v6.0.0) #195

temka1234 opened this issue Oct 30, 2020 · 3 comments
Assignees
Labels
type: bug/fix This is a bug or at least needs a fix workaround-1: obvious Obvious workaround

Comments

@temka1234
Copy link

Nested list formgroup not updated on patch after one second (OnPush). Here is example:
https://stackblitz.com/edit/angular-ivy-g2axl3

@agallardol
Copy link

agallardol commented Nov 2, 2020

What version of angular are you using?
I had the same issue with v6.0.0, I tought it happens because I'm using Angular 9
As a workaround I used the directive described in #93

@maxime1992
Copy link
Contributor

What version of angular are you using?

The title is

List subform component not updated with OnPush strategy (v6.0.0)

=)

So yep apparently rewrite is not fixing it, we'll have to investigate further

maxime1992 added a commit to maxime1992/cloudnc-ngx-sub-form-issue195 that referenced this issue Dec 30, 2020
@maxime1992 maxime1992 self-assigned this Dec 30, 2020
@maxime1992 maxime1992 added type: bug/fix This is a bug or at least needs a fix workaround-1: obvious Obvious workaround labels Dec 30, 2020
@maxime1992
Copy link
Contributor

@temka1234 this drove me insane for a bit 🙃.

I thought we fixed it with https://github.com/cloudnc/ngx-sub-form/releases/tag/v6.0.0-feat-rewrite.6 and https://github.com/cloudnc/ngx-sub-form/releases/tag/v6.0.0-feat-rewrite.7

but bumping the version on stackblitz didn't seem to change anything 😞. So I thought something was broken. At some point I started to doubt what was happening on stackblitz and created a local repro + copied your code over and guess what? It's working just fine ✔️.

You can find the repro here:

https://github.com/maxime1992/cloudnc-ngx-sub-form-issue195

If you want this to work in your app remember to update to at least 6.0.0-feat-rewrite.7 👍

Closing as the fix is already deployed, feel free to reopen if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug/fix This is a bug or at least needs a fix workaround-1: obvious Obvious workaround
Projects
None yet
Development

No branches or pull requests

3 participants