Explain why empty form arrays are not included in this.formGroupValues

[jaycetde]

ngx-sub-form/projects/ngx-sub-form/src/lib/ngx-sub-form.component.ts

Line 172 in 6a39e4a

if (values.length > 0 && values.some(x => !isNullOrUndefined(x))) {

It's not difficult to work around, but could someone please provide some insight as to why an empty FormArray is not included in this.formGroupValues? I would expect it to return an empty array. Now, wherever need to work with these items, I have to write it like this: (this.formGroupValues.myArray || []).filter(...)

If there's a good reason for it, I would like to know what it is.

This package is awesome. Thank you

[maxime1992]

Hi @jaycetde it sounds like this was intended to manage the formGroupErrors and impacted the formGroupValues.

We've been working on a complete rewrite and did decide not to reuse that pattern which is overly complicated and not easy to read (+error prone apparently 😅).

Hopefully it's solve there, I'll check later on 👍 (and keep that one opened in the meantime)

[maxime1992]

☝️ I marked as has PR and assigned myself so that no else take this one because I think the rewrite will solve it.

[maxime1992]

Hey @jaycetde 👋 just to let you know, I had a quick look to see if this would be solved in the new version and it is ✔️. In the new version, formGroupValues is gone and you'd simply access the values like this: form.formGroup.value :)

It's only published as a pre-release for now and the doc is not yet updated but if you want to give it a go you can have a look on the new branch here: https://github.com/cloudnc/ngx-sub-form/tree/feat-rewrite/src/app/main-rewrite where all the forms are using the new approach 😸 Not too hard to understand if you're already familiar with ngx-sub-form 👍