Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ngx*RootFormComponent should force to implement the remap methods if 2 interfaces are provided #133

Closed
maxime1992 opened this issue Feb 5, 2020 · 3 comments · Fixed by #188
Closed

Ngx*RootFormComponent should force to implement the remap methods if 2 interfaces are provided #133

maxime1992 opened this issue Feb 5, 2020 · 3 comments · Fixed by #188
Assignees
@maxime1992
Labels
released on @feat-rewrite released scope: lib Anything related to the library itself state: has PR A PR is available for that issue type: feature This is a new feature

Comments

@maxime1992
Copy link
Contributor

When using a Ngx*RootFormComponent if we provide 2 interfaces to remap, we don't have to implement transformToFormGroup and transformFromFormGroup.

I just had a bug because of that 😅
@maxime1992 maxime1992 added scope: lib Anything related to the library itself type: feature This is a new feature labels Feb 5, 2020
maxime1992 added a commit that referenced this issue Feb 10, 2020
@maxime1992
feat(lib): add NgxRootFormRemapComponent and `NgxAutomaticRootFormR…
54c234e 
…emapComponent`

BREAKING CHANGES: You'll need to be more precise when using `NgxRootFormComponent` and `NgxAutomaticRootFormComponent`. They now have both a `remap` version. It was very easy to forget about the remap methods previously and some bugs could quickly sneak in.

This closes #133
@maxime1992 maxime1992 mentioned this issue Feb 10, 2020
Closed
@maxime1992 maxime1992 added the state: has PR A PR is available for that issue label Feb 10, 2020
@maxime1992 maxime1992 self-assigned this Feb 10, 2020
maxime1992 added a commit that referenced this issue Feb 10, 2020
@maxime1992
feat(lib): add NgxRootFormRemapComponent and `NgxAutomaticRootFormR…
d931322 
…emapComponent`

BREAKING CHANGES: You'll need to be more precise when using `NgxRootFormComponent` and `NgxAutomaticRootFormComponent`. They now have both a `remap` version. It was very easy to forget about the remap methods previously and some bugs could quickly sneak in.

This closes #133
@maxime1992 maxime1992 mentioned this issue Feb 24, 2020
Closed
@maxime1992
Copy link
Contributor Author

Discussed with @zakhenry.

@zakhenry please revisit the MR #137 as #144 is not possible yet (and we ended up with a bug on prod because we forgot to remap)

@maxime1992 maxime1992 mentioned this issue May 6, 2020
Closed
maxime1992 added a commit that referenced this issue Jun 15, 2020
@maxime1992
feat: rewrite of ngx-sub-form without inheritance
719d640 
This is a major architecture change which is brought without any breaking change 😄!

We've split up the code base in 2: Old one and new one.
The old one hasn't moved at all but is now deprecated (not removed yet!).
You can keep using the old one for a bit and have a smooth/incremental update to use the new API.

Few changes that you have to note with the new API:
- Only works with Angular 9 or more
- The app needs to have Ivy activated (this is because we use `ɵmarkDirty` internally. If it ever gets removed we'll probably have to ask to provide the `ChangeDetectorRef` but we were able to around this for now!)
- We got rid of inheritance 🙌
- Form errors on a FormArray are now an object instead of an array. Previously the array contained null values on all the fields without any error. It's now an object containing only the ones with errors and you can access them using the index

Please start upgrading to the new API as soon as possible as we stop supporting the old API as of today and will remove it in a near release.

This closes #171 for the major architectural changes and also the following issues as a result:
- closes #82
- closes #86
- closes #93
- closes #133
- closes #143
- closes #144
- closes #149
- closes #160
- closes #168
@maxime1992
Copy link
Contributor Author

🎉 This issue has been resolved in version 5.2.0-feat-rewrite.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maxime1992 maxime1992 linked a pull request Oct 11, 2020 that will close this issue
feat: rewrite of ngx-sub-form without inheritance #188
Merged
zakhenry pushed a commit that referenced this issue Oct 23, 2020
@maxime1992 @zak-cloudnc
feat: rewrite of ngx-sub-form without inheritance
8d3400c 
This is a major architecture change which is brought without any breaking change 😄!

We've split up the code base in 2: Old one and new one.
The old one hasn't moved at all but is now deprecated (not removed yet!).
You can keep using the old one for a bit and have a smooth/incremental update to use the new API.

Few changes that you have to note with the new API:
- Only works with Angular 9 or more
- The app needs to have Ivy activated (this is because we use `ɵmarkDirty` internally. If it ever gets removed we'll probably have to ask to provide the `ChangeDetectorRef` but we were able to around this for now!)
- We got rid of inheritance 🙌
- Form errors on a FormArray are now an object instead of an array. Previously the array contained null values on all the fields without any error. It's now an object containing only the ones with errors and you can access them using the index

Please start upgrading to the new API as soon as possible as we stop supporting the old API as of today and will remove it in a near release.

This closes #171 for the major architectural changes and also the following issues as a result:
- closes #82
- closes #86
- closes #93
- closes #133
- closes #143
- closes #144
- closes #149
- closes #160
- closes #168
maxime1992 added a commit that referenced this issue Nov 21, 2021
@maxime1992
feat: rewrite of ngx-sub-form without inheritance
fef8cce 
This is a major architecture change which is brought without any breaking change 😄!

We've split up the code base in 2: Old one and new one.
The old one hasn't moved at all but is now deprecated (not removed yet!).
You can keep using the old one for a bit and have a smooth/incremental update to use the new API.

Few changes that you have to note with the new API:
- Only works with Angular 9 or more
- The app needs to have Ivy activated (this is because we use `ɵmarkDirty` internally. If it ever gets removed we'll probably have to ask to provide the `ChangeDetectorRef` but we were able to around this for now!)
- We got rid of inheritance 🙌
- Form errors on a FormArray are now an object instead of an array. Previously the array contained null values on all the fields without any error. It's now an object containing only the ones with errors and you can access them using the index

Please start upgrading to the new API as soon as possible as we stop supporting the old API as of today and will remove it in a near release.

This closes #171 for the major architectural changes and also the following issues as a result:
- closes #82
- closes #86
- closes #93
- closes #133
- closes #143
- closes #144
- closes #149
- closes #160
- closes #168
@github-actions
Copy link

🎉 This issue has been resolved in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxime1992 maxime1992

Labels
released on @feat-rewrite released scope: lib Anything related to the library itself state: has PR A PR is available for that issue type: feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rewrite of ngx-sub-form without inheritance cloudnc/ngx-sub-form
1 participant
@maxime1992