Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who's using ngx-sub-form? #112

Open
maxime1992 opened this issue Nov 11, 2019 · 7 comments
Open

Who's using ngx-sub-form? #112

maxime1992 opened this issue Nov 11, 2019 · 7 comments
Labels
state: community Someone from the community is working on this issue or submitted that PR type: RFC/discussion/question This issue is about RFC, discussion or a question

Comments

@maxime1992
Copy link
Contributor

maxime1992 commented Nov 11, 2019

Hi everyone 👋!

Out of curiosity, we'd love to heard from people using ngx-sub-form whether you're using it for small side projects or larger projects at work 👍.

If you feel like sharing with us know, feel free to use the following template (or not):

- I/we use `ngx-sub-form` [for personal projects]/[at work (COMPANY_NAME), with at least X people using the library]
- I/we are using `ngx-sub-form` on prod for X projects that are used by more than X customers every [days/months/years]
- Searching for `from 'ngx-sub-form'` in the whole code base gives me X hits
- So far my/our experience with `ngx-sub-form` has been [awful/good/great/awesome]
- If I could vote for an epic feature it would be:
- Anything else you want to share with us:

(feel free to tweak the above as you please and answer only what can/want)

Thanks for taking the time to share 🙏!

@maxime1992 maxime1992 added state: community Someone from the community is working on this issue or submitted that PR type: RFC/discussion/question This issue is about RFC, discussion or a question labels Nov 11, 2019
@maxime1992 maxime1992 pinned this issue Nov 11, 2019
@dscoblen
Copy link

We are using ngx-sub-form at Cohesity, and are working on migrating most of our form components to use it. Thank you for you work on this library, it is really solid.

@cbleu
Copy link

cbleu commented Dec 22, 2019

I am using ngx-sub-form on a middle size project for a customer and friend.
Dynamic Forms are at the centre of the project we spend lot of time to search the best (less worse ;) ) architecture for the project and we found your lib.
Your lib is quite useful for us, even if some previous limitations forced us to create some workarounds and big boilerplates !
We have not yet find a clean architecture and i am sure that i miss-use your lib. If i really understand a day, the deep concept of your lib, i will use it much more efficiently !
But as you know, time and deadlines are our enemy so we have not enough time to reorganize the project 'again' right now.
Maybe maxime your 'eyes' on some parts of our project will help us a day to really use your nice lib well !
Thanks a lot for that nice piece of code.

@maxime1992
Copy link
Contributor Author

@dscoblen thanks for the kind words, we appreciate 😄!

@cbleu also thanks for the detailed comment 👌!

we spend lot of time to search the best (less worse ;) ) architecture for the project

We did too initially. Unfortunately we couldn't find anything that was fitting our need and after building ngx-sub-form internally we thought it might be useful for others and decided to publish it :)

less worse ;)

Yes! A built in support from angular would be great 🙏
You can also track this interesting thread to improve reactive forms: angular/angular#31963

Your lib is quite useful for us, even if some previous limitations forced us to create some workarounds and big boilerplates !

Please do report them as separated issues and if it's legit and we can help we will.

We have not yet find a clean architecture and i am sure that i miss-use your lib. If i really understand a day, the deep concept of your lib, i will use it much more efficiently !

The main concept of the library is hidden behind a built in feature of angular: Control Value Accessor. Google it and you'll be able to find really good articles (and YT videos especially from ng-conf) where you can learn more around that. ngx-sub-form aims to reduce the boilerplate required for that and we built a few features on top of it too (+handled a few known bugs so ngx-sub-form users don't have to 🙌) . If you feel like digging into the code the core of the lib is in one file: ngx-sub-form.component.ts

If you want to find examples, you can also look into our demo project in the src folder or read a blog post about ngx-sub-form.

your 'eyes' on some parts of our project will help us a day to really use your nice lib well !

Feel free to create some stackoverflow questions to show where you're at and what are your issues 👍

@MonsieurMan
Copy link

I introduced it to simplify a form that was growing well over the 700 hundred lines in our of our project at work. It was the dreaded part of the app, but now when we have to change it, it feels like changing the color of a button, you know where and how even before opening the project.
I really like the added safeguards it adds and how it's simple to decouple parts of the form.

The only thing I really struggle with each time I use this lib, is when I have a form control that is not really an input the user would type in.

Per example we have a few forms where we select a user from a modal that searches in the LDAP. And I'd like to display the selected user in a custom component that is not editable by hand. I ended up putting it in a read-only input but that's really hacky.

@maxime1992
Copy link
Contributor Author

@MonsieurMan thanks for the details on the project and how ngx-sub-form helped you solved them!

Can you create an issue for the thing you're struggling with? I'll try to help you out and maybe improve our docs and/or examples 😺 (but not in this thread)

@anschm

This comment was marked as off-topic.

@maxime1992

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: community Someone from the community is working on this issue or submitted that PR type: RFC/discussion/question This issue is about RFC, discussion or a question
Projects
None yet
Development

No branches or pull requests

5 participants