Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use negative text-indent on Heading component? #1751

Open
gerardo-rodriguez opened this issue Apr 26, 2022 · 2 comments
Open

Use negative text-indent on Heading component? #1751

gerardo-rodriguez opened this issue Apr 26, 2022 · 2 comments
Labels
👷 dev 🎨 design Requires visual, UX or UI design decisions ⁉️ question Further information is requested

Comments

@gerardo-rodriguez
Copy link
Member

gerardo-rodriguez commented Apr 26, 2022

I'm wondering if we should add a negative text-indent to the headings? (Only larger headings? Not sure.)

I noticed it at some point and now I can't unsee it. In the screenshots below, it feels better when the heading has a slight negative text-indent, in my opinion.

@tylersticka, how do you feel about this?

With no negative text-indent (as things currently are)

Screen Shot 2022-04-26 at 5 58 35 AM

Screen Shot 2022-04-26 at 5 52 05 AM

With a negative text-indent

Screen Shot 2022-04-26 at 5 58 26 AM

Screen Shot 2022-04-26 at 5 53 26 AM

@gerardo-rodriguez gerardo-rodriguez added ⁉️ question Further information is requested 🎨 design Requires visual, UX or UI design decisions size:1 👷 dev labels Apr 26, 2022
@tylersticka
Copy link
Member

I've often thought about this with letters like "T" that naturally have a lot of whitespace on their left side. I thought I'd see how this change would fare on other initial letters used in our names.

Here's what I thought, first at the suggested -0.1em and then after halving that to -0.05em.

Initial -0.1em -0.05em
A
C
D
G
J
M
P
S
T

My feeling is that the -0.1em is too much except for initials with a large left curve or a large amount of confined white space. But when I reduced that a bit, I preferred the version with negative indentation for all but the letter "A," the left endpoint feeling a tad less aligned with that change applied.

But this was at desktop sizes. I tried the test again at smaller sizes, and I found that the negative indent always looked "off" to my eye.

So the potential solution would be to only apply an indent when the font-size exceeds a certain value. But how would we do that when we're using things like clamp?

Would we mathematically figure out an equation to clamp a negative indent as well?

@gerardo-rodriguez
Copy link
Member Author

Thanks for digging deeper into this, @tylersticka!

I was mostly curious when I opened the issue. Since there isn't a straightforward solution, I agree we leave this in the backlog for now, as you suggested. It's not a high priority for me. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷 dev 🎨 design Requires visual, UX or UI design decisions ⁉️ question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants