Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to GitHub deployments parity with wrangler-action #333

Open
Maximo-Guk opened this issue Nov 26, 2024 · 1 comment
Open

Follow up to GitHub deployments parity with wrangler-action #333

Maximo-Guk opened this issue Nov 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Maximo-Guk
Copy link
Member

A few follow up items for deployments parity from user feedback left on #325.

  • Don't require GitHub token as an action input. Default its value to github.token (see actions/checkout for a great example), then let users turn features on/off using boolean inputs. This is a lot less confusing and aligns with the rest of the ecosystem.

  • Accept environment name as input. Named GitHub environments can hold configurations, so migrating users might need this action's environment names to match their old ones, so that those configurations will still apply. And one repo can deploy multiple Wrangler apps, so their environment names must be configurable or else they will collide.

  • Provide separate inputs to enable deployments vs. job summaries. Deployments add a lot of noise on the Conversation tab, whereas job summaries add a lot of noise on the Checks tab. Ideally users could choose how much noise they want.

@Maximo-Guk Maximo-Guk added the enhancement New feature or request label Nov 26, 2024
@benbek
Copy link

benbek commented Dec 5, 2024

In addition, supplying an environment name should propagate through the Deployments list on the repository. (currently I don't see anything on the Deployments list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants