Error: Package manager is not detected

[vipulgupta2048]

With the latest wrangler-action version, we were getting the following error due to the latest changes.

file:///home/runner/work/_actions/cloudflare/wrangler-action/5a6b8d26847f6ab196fd2441fc52dc87b72c1b99/dist/index.mjs:2923
    throw new Error("Package manager is not detected");
          ^

Error: Package manager is not detected
    at realPackageManager (file:///home/runner/work/_actions/cloudflare/wrangler-action/5a6b8d26847f6ab196fd2441fc52dc87b72c1b99/dist/index.mjs:2923:11)
    at file:///home/runner/work/_actions/cloudflare/wrangler-action/5a6b8d26847f6ab196fd2441fc52dc87b72c1b99/dist/index.mjs:2925:48

Adding packageManager: npm to the actions YML file, in our case, resolved the issue after some digging around from the recent commits. Maybe create this as optional since this wasn't needed before? Or detecting it?

[ghost]

What does your .yml file look like with the packageManager: npm (where does it go)? I'm not very familiar with Github Action syntax.

[vipulgupta2048]

Here's an example:

- name: Deploy to Cloudflare Pages
        uses: cloudflare/[email protected] 
        with:
          apiToken: ${{ secrets.CF_API_TOKEN }}
          accountId: ${{ secrets.CF_ACCOUNT_ID }}
          wranglerVersion: '3.5.1' # latest - https://www.npmjs.com/package/wrangler
          preCommands: wrangler --version
          command: pages publish --branch $CF_BRANCH --project-name=$cloudflare_website  build/ | tee -a $GITHUB_STEP_SUMMARY
          packageManager: npm      # This is what you add

[HeilAsuka]

I addpackageManager: npmbeforecommand:xxxxxx,this error disappear. 😃 Thanks.

[vipulgupta2048]

Yeah the location of the packageManager: npm or whatever package manager you use, shouldn't matter. Although folks looking at this issue if you can add your reaction to help the maintainers see this is not an isolated issue, then that be great. AFK for a couple of days, otherwise would submit a change myself.

[1000hz]

Sorry about the trouble here. packageManager should indeed be optional. I think the best course of action is for us to fallback to npm instead of throwing an error if packageManager isn't specified and we can't infer the appropriate one to use based on lockfiles present in your repo. If you do specify packageManager, we should use that instead of trying to infer it. I'll work on a fix for this.

[vipulgupta2048]

Thanks for looking into this @1000hz Are you considering only the JS ecosystem package manager with this property. Clarification on what this does might be helpful, thanks!

[1000hz]

@vipulgupta2048 yes, only JS package managers are supported. Specifically: npm, yarn, pnpm (with bun support being added soon)

[1000hz]

[email protected] has been released which fixes this issue. You can safely remove the packageManager: npm from your workflow if you added it as a result of this bug.

[vipulgupta2048]

Thanks @1000hz appreciate the response. Cheers!