Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: clojurers script runner shows EOF error after successful script run #60

Open
erkkikeranen opened this issue May 16, 2020 · 1 comment

Comments

@erkkikeranen
Copy link
Member

erkkikeranen commented May 16, 2020

even if script succeeds, it returns an error condition

$ cargo run -- examples/hello_world.clj
Hello, world
#Condition["Tried to read empty stream; unexpected EOF"]

expected success case:

no more output after Hello, world

@phrohdoh
Copy link
Contributor

phrohdoh commented Jul 8, 2021

The read function will need to return Result/Option of Value (or a similar solution). Currently it returns this error-indicating Condition when there are no more lines to read (which is certainly not what the user expects).

Edit: #62 (comment) indicates returning Value itself is desired, with the solution to this being ignoring a particular Condition ret val. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants