Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of compilation warnings since update to Emacs 29 #3606

Open
DerGuteMoritz opened this issue Jan 16, 2024 · 4 comments · May be fixed by #3617
Open

Lots of compilation warnings since update to Emacs 29 #3606

DerGuteMoritz opened this issue Jan 16, 2024 · 4 comments · May be fixed by #3617
Assignees
@vemv

Comments

@DerGuteMoritz
Copy link
Contributor

Expected behavior

Loading CIDER should work without warnings.

Actual behavior

Since upgrading from Emacs 28 to 29, I get a lot of compilation warnings when loading CIDER. They pop up in a *Warnings* buffer like this:

2024-01-16_11-07-18_cider

Here's the full list.

Steps to reproduce the problem

Load CIDER in Emacs 29.1 with native compilation enabled.

Environment & Version information

CIDER version information

;; CIDER 1.13.0 (Santiago), nREPL 1.0.0
;; Clojure 1.11.1, Java 17.0.7

Lein / Clojure CLI version

Clojure CLI version 1.11.1.1413

Emacs version

GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw3d scroll bars)

Operating system

NixOS 24.05 (Uakari)

JDK distribution

OpenJDK
@vemv
Copy link
Member

vemv commented Jan 16, 2024

Thanks much for the heads up. As far as CircleCI goes, we run test-lint only in Emacs 28. It seems about time that we run it for 29 instead.

(probably it's not a good idea to lint for our entire matrix - I think I've seen issues that if solved for one version, then create an issue for a different version, and so on)

@ikappaki may enjoy fixing this, but that's only an invitation :)

@bbatsov
Copy link
Member

bbatsov commented Jan 16, 2024

(probably it's not a good idea to lint for our entire matrix - I think I've seen issues that if solved for one version, then create an issue for a different version, and so on)

I agreed. Generally it's best to lint only on the latest supported version, at typically the lint warning are accretive anyways.

@vemv vemv mentioned this issue Jan 17, 2024
Merged
@vemv vemv self-assigned this Feb 1, 2024
@vemv vemv linked a pull request Feb 1, 2024 that will close this issue
Open
@purcell
Copy link
Member

purcell commented Feb 2, 2024

Somewhat relatedly: I might suggest adding Emacs HEAD to the matrix too, but allowing failures for that version. Then you kinda get a heads-up about potential future issues. I noticed that sesman doesn't compile in current Emacs HEAD, for example, so Cider is uninstallable there. It could be an Emacs bug, but who knows?

@bbatsov
Copy link
Member

bbatsov commented Feb 2, 2024

Hmm, I thought we had done it, but I guess this changed amidst all the CI tweaks. It's always a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vemv vemv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address most Emacs 29 warnings clojure-emacs/cider
4 participants
@purcell @DerGuteMoritz @bbatsov @vemv