Add multi geographies to search API #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgorrie
force-pushed
the
multi_georgraphies
branch
3 times, most recently
from
0889ae6 to
31dc0dd
Compare
jamesgorrie
changed the title
jamesgorrie
force-pushed
the
multi_georgraphies
branch
from
7a61af6 to
cdcb565
Compare
jamesgorrie
changed the title
jamesgorrie
commented
Dec 10, 2024
katybaulch
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
This adds the ability to search multiple geographies via the API, but doesn't add support for multi geographies in the admin backend (slight misinterpretation of the ticket perhaps - but this work still needed doing so I'm going to link the right ticket and merge this) :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of https://linear.app/climate-policy-radar/issue/PDCT-1404/admin-service-support-multiple-geographies
Allows the API to receive geography as an list i.e.
geography=zambia&geography=zimbabwe.I've used the built in parsers for the geography qs - which breaks convention, but avoids us having to add new parsers to
get_query_params_as_dict.As a secondary refactor to this PR - we could lean heavier into that and be more explicit about out URL params.
Proposed version
Type of change
How Has This Been Tested?
Integration tests