Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorflow 2 C&W2 implementation targeted bug #1228

Open
ugorsahin opened this issue Mar 8, 2022 · 0 comments
Open

Tensorflow 2 C&W2 implementation targeted bug #1228

ugorsahin opened this issue Mar 8, 2022 · 0 comments

Comments

@ugorsahin
Copy link

Hello, I have seen one possible bug in the tensorflow C&W2 implementation.

The targeted parameter does not pass to function body, instead it is defined with respect to y parameter being None or not. This causes problems when labels are explicitly given in untargeted scenario.


self.targeted = y is not None

There might be two ways to fix this:

  • One would be
    self.targeted = targeted
  • The other solution would be replacing default value of targeted to None and fixing line
    targeted = None
    on the argument list and
if targeted is not None:
    self.targeted=targeted
else:
    self.targeted = y is not None

in the body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant