Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array and string offset access syntax with curly braces is deprecated #10

Open
timbertens opened this issue Oct 3, 2020 · 8 comments
Open

Comments

@timbertens
Copy link

On PHP 7.4.x curly braces are no longer supported, resulting in an error when using this component.
The problem actually occurs in one of the dependencies, being campaignmonitor/createsend-php
The issue over there is solved since version 6.1.1 of that component, see campaignmonitor/createsend-php#101

But this component still uses version 5.1.3 of the mentioned dependency. Could you please update the composer.json?
This is related to clearbold/craft-campaignmonitor-service#3 (and might be to all your components using campaignmonitor/createsend-php)

@bartrylant
Copy link

Any updates on this issue? Plugin is unusable like this…

@heymarkreeves
Copy link
Member

Sorry about that. I've pushed an update with the updated requirement. Let me know how that works?

@timbertens
Copy link
Author

It breaks everything I'm afraid. Apparently CM requires now to send a ConsentToTrack field, see https://www.campaignmonitor.com/api/subscribers/
I've trying to add it to ListService.php, but now it fails with 'Failed to deserialize your request.'

@heymarkreeves
Copy link
Member

heymarkreeves commented Nov 24, 2020

I quickly added that to v1.1.11. Does that fix it?

@timbertens
Copy link
Author

timbertens commented Nov 24, 2020

yes, of course it has to be 'yes' not true like I tried ... too many hours behind my screen ..
It works now !

@timbertens
Copy link
Author

Can you push a new version to make sure ?

@heymarkreeves
Copy link
Member

Great! v1.1.11 is the new version. You should see that as an available update via Composer.

Do you think consent to track should be a configurable setting or parameter rather than defaulted to 'yes'?

@timbertens
Copy link
Author

yes, I just noticed it was already a new version ... great & thanks
Yeah maybe in an ideal world this should be configurable or to be included in the form, but for now that's ok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants