Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_variable depreciated in 2.6.0 causes error in function manage_notifications #5

Open
Gnative opened this issue Mar 13, 2014 · 1 comment

Comments

@Gnative
Copy link

Gnative commented Mar 13, 2014

Fixed by adding ee_version check to construct

    //normal
    if (defined('APP_VER'))
    {
        $this->ee_version = APP_VER;
    }
    //install wizard
    else if (isset(ee()->version))
    {
        $this->ee_version = ee()->version;
    }

And in manage_notifications function

    //set_variable depracated in 2.6.0
    if (version_compare($this->ee_version, '2.6.0', '>='))
    {
        $this->EE->view->cp_page_title = 'Manage Notifications';
    }
    else
    {
        $this->EE->cp->set_variable('cp_page_title', 'Manage Notifications');
    }
@heymarkreeves
Copy link
Member

Thanks! Could you do a pull request so I can get your code directly?

@heymarkreeves heymarkreeves mentioned this issue Aug 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants