Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.Zepto and window.$ should not be set #4

Open
tjenkinson opened this issue Apr 10, 2016 · 2 comments
Open

window.Zepto and window.$ should not be set #4

tjenkinson opened this issue Apr 10, 2016 · 2 comments

Comments

@tjenkinson
Copy link

I have tried to remove where they're set but because it's minified I'm having difficulty.

Could this not be an unminified version, as when it's used in clappr it will be minified there as part of the build process?

@kslimani
Copy link
Contributor

👍 yes please, also note if version is not minified, it may take even less space when minified as part of Clappr. (i am also attemtping to track a bug where, in some rare case, trigger method is called on undefined element).

@kslimani
Copy link
Contributor

I think i figured out the trick used here.

@thiagopnts can you confirm me you are proceeding the following please ? :

you go on Zepto builder and check only ajax, callbacks, deferred, event, ie, selector, touch, zepto modules.

Finally you add the following line at end to make it available as node module :

module.exports = Zepto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants