Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure function errors are handled everywhere #98

Open
sivachandran opened this issue Mar 18, 2021 · 0 comments · May be fixed by #102
Open

Make sure function errors are handled everywhere #98

sivachandran opened this issue Mar 18, 2021 · 0 comments · May be fixed by #102

Comments

@sivachandran
Copy link
Contributor

sivachandran commented Mar 18, 2021

There are places, e.g., recordStepXXX in service_request_worker.go where function error value is not checked. This would lead to silent errors and would make Clamp unreliable. So, we need to make sure function error values are handled everywhere in the codebase.

golangci-lint identifies function calls without error handling. We should also search for _ := and _ = string in the codebase to identify function calls where the error is explicitly ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant