Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure HTTP call support #67

Open
dileepbapat opened this issue Oct 28, 2020 · 1 comment
Open

Secure HTTP call support #67

dileepbapat opened this issue Oct 28, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dileepbapat
Copy link

Is your feature request related to a problem? Please describe.
The current HTTP mode is not working with HTTPS for callout in the steps.

Steps to reproduce

POST http://localhost:8080/workflow
Content-Type: application/json

{
  "name": "sometestv2",
  "description": "test",
  "steps": [
    {
      "name": "get_detail",
      "mode": "HTTP",
      "val": {
        "method": "GET",
        "url": "https://api.github.com/users/dileepbapat"
      }
    }
  ]
}

POST http://localhost:8080/serviceRequest/sometestv2

{}

Describe the solution you'd like
Can be different mode HTTPS, but I would say HTTP and HTTPS modes are switched without a change in underlying request semantic. So based on URL scheme https can be supported with existing HTTP mode itself.

@priyaaank priyaaank added the enhancement New feature or request label Oct 29, 2020
@priyaaank priyaaank added this to the Release Thor milestone Oct 29, 2020
@lohith46 lohith46 self-assigned this Nov 3, 2020
@priyaaank priyaaank modified the milestone: Release Thor Nov 3, 2020
@sivachandran
Copy link
Contributor

@dileepbapat @priyaaank Is it still valid? The demo workflow steps call https://run.mocky.io/... (HTTPS) URLs and they are working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants