Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration folder ckeditor5* peerDeps not updated by release script #35

Open
f1ames opened this issue Oct 9, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@f1ames
Copy link
Contributor

f1ames commented Oct 9, 2024

As mentioned in the issue title. The peerDeps should be updated too in integrations folder package.json, to be aligned with ckeditor5* package version from samples directories.

@f1ames f1ames added the bug Something isn't working label Oct 9, 2024
@Dumluregn
Copy link

Stylesheets versions in exports configs are also static:

stylesheets: [
'https://cdn.ckeditor.com/ckeditor5/42.0.0/ckeditor5.css',
'https://cdn.ckeditor.com/ckeditor5-premium-features/42.0.0/ckeditor5-premium-features.css'
],
fileName: 'export-pdf-demo.pdf',
appID: 'cke5-demos',
converterOptions: {
format: 'Tabloid',
margin_top: '20mm',
margin_bottom: '20mm',
margin_right: '24mm',
margin_left: '24mm',
page_orientation: 'portrait'
},
tokenUrl: false
},
exportWord: {
stylesheets: [
'https://cdn.ckeditor.com/ckeditor5/42.0.0/ckeditor5.css',
'https://cdn.ckeditor.com/ckeditor5-premium-features/42.0.0/ckeditor5-premium-features.css'
(probably in other demos as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants