Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wld-cli doesn't extract unknown fragment types #15

Open
bryab opened this issue Aug 21, 2022 · 2 comments
Open

wld-cli doesn't extract unknown fragment types #15

bryab opened this issue Aug 21, 2022 · 2 comments

Comments

@bryab
Copy link
Collaborator

bryab commented Aug 21, 2022

Do you have a good way of extracting fragments out of WLDs that are not yet supported? For example, gequip.wld has 0x26 and 0x27 in it (at least) and the wld-cli extract tool fails to extract them.

@bryab bryab changed the title wld-cli doesn't extract unknown WLDs wld-cli doesn't extract unknown fragment types Aug 21, 2022
@cjab
Copy link
Owner

cjab commented Aug 22, 2022

Funny you mention it. I'm working on some improved error reporting in the parser right now. The plan, and it seems to be working out so far, is to return a collection of errors containing the fragment headers and unparsed bodies of unknown fragments. And hopefully, if I can convince nom to work with me, any parsing errors encountered in known fragments too!

@nickgal
Copy link
Contributor

nickgal commented Oct 29, 2022

Commenting out these lines worked as a quick hack to extract a wld file that isn't fully supported.

if errors.len() > 0 {
return Err(errors);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants